Repository navigation
Make the php command 2 times faster to start - #426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
phpcommand 2 times faster to start:/usr/bin/phpis a proxy that regenerates the PHP configuration when aPHP_*variable changed (e.g.docker exec -e PHP_INI_MEMORY_LIMIT=1G). To detect it, it calledsudoand started PHP a first time on each call.It now compares a fingerprint of the
PHP_*variables in bash, and only usessudoand PHP when they changed.It also detects the removed variables: the configuration was kept unchanged when a
PHP_*variable was removed.Measures (PHP 8.4, amd64, average of 300
php -r ''in a started container):php -r ''real_phpalone: 19 ms)Every
phpcommand benefits: Composer scripts,bin/console, cron jobs, tests...Test plan (required)
New test
test_environmentChangedAfterStart(php-ini.sh). It fails on the current images(
expected [512M -1] but was [512M 512M]).variant-node.shwas not run: the NodeJS images are not modified.Checklist